Skip to content

Ignore punctuation when detecting the language in search_dates #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdrianAtZyte wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ignore punctuation when detecting the language in search_dates #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75a4ae7
Ignore punctuation when detecting the language in search_dates
AdrianAtZyte Oct 2, 2026
1cf0d37
Merge remote-tracking branch 'origin/master' into ignore-punctuation-…
AdrianAtZyte Oct 30, 2026
d24a62b
Cover search with no detected language and no language list
AdrianAtZyte Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions dateparser/languages/locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from collections.abc import Iterable, Iterator, Mapping, Sequence
from functools import cached_property
from itertools import chain, islice, product
from string import punctuation
from typing import TYPE_CHECKING, Any, TypeVar

import regex as re
Expand Down Expand Up @@ -1056,15 +1057,12 @@ def get_wordchars_for_detection(self, settings: "Settings | None") -> set[str]:
"7",
"8",
"9",
":",
"(",
")",
"'",
"q",
"a",
"m",
"p",
" ",
*punctuation,
}
return self._wordchars_for_detection

Expand Down
2 changes: 1 addition & 1 deletion dateparser/search/text_detection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def character_check(self, date_string: str, settings: Settings) -> None:
]
self.languages = [
i for j, i in enumerate(self.languages) if j not in indices_to_pop
]
] or [self.languages[0]]

@apply_settings
def _best_language(
Expand Down
18 changes: 18 additions & 0 deletions tests/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,6 +1114,15 @@ def test_detection(self, shortname: str, text: str) -> None:
("21 марта", datetime.datetime(2001, 3, 21, 0, 0)),
],
),
param(
text="july 2018 - december 2020",
languages=["en", "fr"],
settings={"PREFER_DAY_OF_MONTH": "first"},
expected=[
("july 2018", datetime.datetime(2018, 7, 1, 0, 0)),
("december 2020", datetime.datetime(2020, 12, 1, 0, 0)),
],
),
param(
text="um 10 Uhr am 5. Mai 2021",
languages=["de"],
Expand All @@ -1128,10 +1137,19 @@ def test_detection(self, shortname: str, text: str) -> None:
settings=None,
expected=[("1990 am 3. März in", datetime.datetime(1990, 3, 3, 0, 0))],
),
param(
text="20/10/2020 06:00 am",
languages=["en"],
settings=None,
expected=[
("20/10/2020 06:00 am", datetime.datetime(2020, 10, 20, 6, 0))
],
),
# Dates not found
param(text="", languages=None, settings=None, expected=None),
# Language not detected
param(text="Привет", languages=["en"], settings=None, expected=None),
param(text="Привет", languages=None, settings=None, expected=None),
# ZeroDivisionError
param(
text="DECEMBER 21 19.87 87",
Expand Down
Loading