Repository navigation
chore(deps): keep Dependabot off majors the fontkit fork decides - #565
Merged
Merged
Conversation
Dependabot keeps opening major bumps it can never land for the vendored fontkit build's dependencies. #559 (dfa 1.2.0 to 2.0.0) is the example: every test failed to load, because the build imports dfa's default export and dfa 2 only has a named `StateMachine`, and `publishable` failed because `scripts/vendor-fontkit.mjs --check` holds package.json to the ranges the windowkit fork declares. This ignores semver-major updates for the nine dependencies the fork declares: `@swc/helpers`, `brotli`, `clone`, `dfa`, `fast-deep-equal`, `restructure`, `tiny-inflate`, `unicode-properties` and `unicode-trie`. `@swc/helpers` is 0.x, so its minors are ignored too, since a 0.6 is as far outside `^0.5.12` as a major. Updates inside the ranges still come through and only move the lockfile, as `@swc/helpers` 0.5.24 does in #564. A major arrives when the fork moves to it, through the vendor script. The list matches the dependencies in the fork's v2.0.4-windowkit.4 tarball, the release `lib/vendor/fontkit.js` names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot keeps opening major bumps it can never land for the vendored fontkit build's dependencies. #559 (dfa 1.2.0 to 2.0.0) is the example: every test failed to load, because the build imports dfa's default export and dfa 2 only has a named
StateMachine, andpublishablefailed becausescripts/vendor-fontkit.mjs --checkholds package.json to the ranges the windowkit fork declares.This ignores semver-major updates for the nine dependencies the fork declares:
@swc/helpers,brotli,clone,dfa,fast-deep-equal,restructure,tiny-inflate,unicode-propertiesandunicode-trie.@swc/helpersis 0.x, so its minors are ignored too, since a 0.6 is as far outside^0.5.12as a major. Updates inside the ranges still come through and only move the lockfile, as@swc/helpers0.5.24 does in #564. A major arrives when the fork moves to it, through the vendor script.The list matches the dependencies in the fork's v2.0.4-windowkit.4 tarball, the release
lib/vendor/fontkit.jsnames.