Repository navigation
Conversation
The embedded R8 rules now match JsonAdapter explicitly to retain its generic signature. The rule permits shrinking and obfuscation, has no member wildcard, and does not match subclasses or other Moshi types; it omits allowoptimization to follow R8 full-mode signature guidance. The diff also adds a test asserting that the resource contains the exact rule and records the fix in the changelog. Fixes square#1663
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedded R8 rules now match JsonAdapter explicitly to retain its generic signature. The rule permits shrinking and obfuscation, has no member wildcard, and does not match subclasses or other Moshi types; it omits allowoptimization to follow R8 full-mode signature guidance. The diff also adds a test asserting that the resource contains the exact rule and records the fix in the changelog. With R8 full mode, Moshi can reject otherwise valid @toJson and @FromJSON methods that take JsonAdapter delegates, throwing IllegalArgumentException when creating an adapter. R8 full mode can strip generic signatures from types unmatched by keep rules. Without JsonAdapter's signature, reflection exposes a raw delegate parameter, so Moshi's parameter validation fails and delegate binding cannot recover the type argument.
Testing: Tests for the moshi change live in
moshi/src/test/java/com/squareup/moshi/MoshiProguardRulesTest.kt.Fixes #1663