Repository navigation
Keep taskbar search box away from the tray #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6a3d3bc
Keep the taskbar search box clear of the notification area
ArneBouten fa335b6
Avoid moving the taskbar search box during short taskbar reflows
ArneBouten ef7d8be
Ignore tray icon animations when placing the taskbar search box
ArneBouten 9ea9d51
Wait longer before moving the taskbar search box into freed space
ArneBouten e73ee0b
Drop the move delay and the tray retries
ArneBouten 4ede9ea
Follow the tray right away
ArneBouten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the increasing timeouts actually work as intended in practice here.
During an Explorer restart Windows fires taskbar events that keep the existing
_repositionTimeractive (firing every 150 ms). Because_repositionTimertriggersApplyMeasuredLayoutso quickly, it will increment_incompleteLayoutRetriesevery 150 ms and burn through all 5 retries in under a second so the increasing timeouts never really get used anyway.Wouldn't it be much simpler to just drop the extra timer and retries and do something like:
If the tray really isn't ready yet for a split second while Explorer loads, we simply do nothing and keep our current position. As soon as Explorer finishes setting up the tray, it will fire fresh taskbar events anyway, which will automatically trigger
UpdatePosition()and place the box properly.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, they burned through in under a second anyway. Replaced with
if (!layout.HasTray) return;.