Skip to content

Make the preview pane resizable - #824

Open
ArneBouten wants to merge 1 commit into
srwi:developfrom
ArneBouten:feature/resizable-preview-pane
Open

ArneBouten wants to merge 1 commit into
srwi:developfrom
ArneBouten:feature/resizable-preview-pane

Conversation

@ArneBouten

Copy link
Copy Markdown
Contributor

Closes #823

  • Drag the left edge of the preview pane to change its width. The width is saved (default 380 px, as before).
  • When the window is too small, the pane gets narrower (down to 240 px) so the results keep at least 240 px, and it grows back once there's room again.

Tested on Windows 11 26H2 (1920×1080, 100%).

Image

Drag the left edge of the preview pane to change its width. The width is saved, and the pane gets narrower when the window is too small to fit it next to the results.

@srwi srwi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool, thank you!

I just left a minor code style comment, but other than that, I'd love to include this in the next version!

private readonly SearchWindowViewModel _viewModel;
private readonly SearchWindowController _controller;
private readonly SearchWindowAnimator _animator;
private readonly ISettings _settings = Ioc.Default.GetRequiredService<ISettings>();

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small cleanup note: since SearchWindow already gets its dependencies via the constructor, could we inject ISettings directly into public SearchWindow(...) instead of calling Ioc.Default.GetRequiredService<ISettings>()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resizable preview pane

2 participants