Repository navigation
fix: select search result on right-click before opening context menu - #826
Closed
Bondrewd-K wants to merge 1 commit into
Closed
Bondrewd-K wants to merge 1 commit into
Bondrewd-K wants to merge 1 commit into
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
Right-clicking a search result no longer acts on whatever row happens to be selected.
OnListViewItemMouseDownnow syncs the selection to the right-clickedListViewItembefore the context menu opens, so every menu entry — Open, Open Path, Open With, Show in Everything, Copy Full Name, Copy File Name, Copy File, Properties, Run as administrator, Windows context menu, custom actions — targets the row under the cursor. This also fixes the "Run as administrator" visibility check and the Shift+right-click system-menu branch, which read the same selection.Root cause: the context menu is attached to every
ListViewItem, but no right-button handler existed, and WPF does not move selection on right-click — soSelectedSearchResultwas always the keyboard/left-click selection, never the right-clicked row.Related issue
Fixes #825
Type of change
Testing
Suggested manual verification (from #825):
.exerow vs a.txtrow: "Run as administrator" must appear only for the.exerow.Screenshots or recordings
None — the only visible change is the right-clicked row taking the existing selection highlight.