Repository navigation
feat(albwaf): add the ability to manage mrs groups - #1863
Merged
Merged
Conversation
stackit_alb_waf_managed_rule_set exposed the mode of every rule only as a read-only attribute, and Update returned "not updatable", so a CRS rule could be set to log-only or disabled only through the API, and was lost whenever the rule set was recreated. rule_modes is an optional map from rule ID to mode. It is applied with PatchManagedRuleSet after create and on update, in place; a rule removed from the map goes back to MODE_ENABLED. Read refreshes only the listed rules, so a mode changed outside Terraform shows as drift. On update the plan carries the groups inventory from state with the planned modes applied, rather than marking the whole inventory unknown. The data source keeps its schema: the resource uses ResourceModel, which embeds the shared Model and adds rule_modes. relates to #1794 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SerseusWasTaken
changed the title
8 tasks done
SerseusWasTaken
marked this pull request as ready for review
October 30, 2026 12:14
SerseusWasTaken
force-pushed
the
feat/modify-mrs-groups-in-terraform
branch
from
October 30, 2026 12:18
6425b35 to
5a9441d
Compare
Fyusel
reviewed
Nov 2, 2026
SerseusWasTaken
force-pushed
the
feat/modify-mrs-groups-in-terraform
branch
from
November 2, 2026 13:59
5a9441d to
f486d38
Compare
Fyusel
reviewed
Nov 3, 2026
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
previously approved these changes
Nov 3, 2026
SerseusWasTaken
force-pushed
the
feat/modify-mrs-groups-in-terraform
branch
from
November 3, 2026 13:34
d712891 to
2203ddf
Compare
Fyusel
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
configured_rulesattribute to configure rules in managed rule setsrelates to #1795 and STACKITTPR-998
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)