Repository navigation
Conversation
|
@dvd233 is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3892.
When an enter transition is interrupted by a leave transition, the first
getAnimations()snapshot can still contain the enter transition. Itsfinishedpromise rejects when the browser replaces it, while the replacementtransition continues running. The previous completion guard detected that
replacement but returned without arranging another completion callback, leaving
the element mounted in its transition state.
This change rechecks the element's pending CSS transitions whenever the current
batch settles. It therefore follows replacement transitions and only completes
once none remain.
Test plan
substitutes the reverse transition, and verifies the element unmounts with
exactly one completion callback.
node node_modules/jest/bin/jest.js --config packages/@headlessui-react/jest.config.cjs --maxWorkers=4 --ci --silentnode node_modules/typescript/bin/tsc -p packages/@headlessui-react/tsconfig.json --noEmit --pretty falsenode node_modules/prettier/bin/prettier.cjs --check packages/@headlessui-react/CHANGELOG.md packages/@headlessui-react/src/hooks/use-transition.ts packages/@headlessui-react/src/hooks/use-transition.test.tsxscripts/build.sh