Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sorting can merge distinct conditional keys or split duplicate identities, changing which property wins.
For example,
clsx({ 'underline flex': true, 'flex underline': false })loses its active classes.Plan actual serialized key identities before mutation and preserve unsafe identity groups.
Keep collision-free supported static keys sortable, including duplicate cohorts that move together safely.
Conservatively preserve keys under spread/computed composition without evaluating expressions.
Carry full key context through global sorter reentry so identity plans and writes agree on whitespace.
Previous class-key support: #155
Verification
clsxevaluation preserved static-collision, nested-spread, and escaped-duplicate results.pnpm run format --check,pnpm run lint, andpnpm run buildpassed.pnpm run test --run: 120 passed, four existing skips.Tested with Node.js 26.12.0, pnpm 10.28.2, and lockfile-pinned Prettier 3.9.6.
The
src/config.tschange is only repository-formatter normalization of an existing signature.Disclosure
Investigated thoroughly with
openai-codex/gpt-6.1-sol(medium reasoning effort), using Oh My Pi as the agent framework.I thoroughly reviewed this contribution with
openai-codex/gpt-6.1-sol(medium reasoning effort).This report is not generic or unreviewed AI-generated output.
Its claims were checked against the cited evidence, and it includes the relevant detail intended to help maintainers resolve the issue.
If reports like this are not useful to the project, please let me know and I will refrain from submitting similar ones.
My intent is to help without wasting maintainer time or energy or discouraging their work.
Thank you for your work.