Repository navigation
fix: dashboard の pnpm を公式イメージから入れ、pnpm 12 に上げてバージョン指定を packageManager に一本化する - #1472
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
pnpmのブートストラップ設定 mise.toml, dashboard/Dockerfile |
mise.tomlのpnpm指定を11に変更しました。Dockerfileはpnpm 11イメージからバイナリを取得し、pnpmとpnpxのリンクを作成します。 |
Renovateの更新グループ renovate.json |
pnpmとghcr.io/pnpm/pnpmのメジャー更新を、pnpm majorグループにまとめるルールを追加しました。 |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: motoki317
Merge Risk: 
Minimal · up to 7dcc6
-
The PR is mergeable with normal validation.
Pre-merge checks: 
4
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Contributor
|
Preview (prod backend + PR dashboard) → https://1472.ns-preview.trapti.tech/ |
…ad of corepack Node.js 26 no longer bundles corepack, so `corepack enable` fails on the Node 26 base image. Copying pnpm from ghcr.io/pnpm/pnpm is the method pnpm recommends; the copied pnpm switches to the version in packageManager, so the image tag only needs the major version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pm version pnpm switches to the version in packageManager whenever the running version differs, so the exact version in mise.toml was never used and had already drifted from package.json. Pin only the major in mise.toml and group the pnpm major updates so the three places move together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pnpm 11 standalone binary links against libatomic, which node slim images lack, so the Dockerfile had to install it with apt. The pnpm 12 binary no longer needs it. 12.15.0 is the newest release that satisfies the 7-day minimum release age. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pirosiki197
force-pushed
the
chore/pnpm-version-source
branch
from
November 1, 2026 10:39
7dcc647 to
af04b10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜやるか
dashboard/DockerfileのRUN corepack enableが失敗する。そのため chore(deps): update node.js to v26 #1469(Node 26 への更新)の Build preview images が落ちている。mise.toml(11.28.10)とdashboard/package.jsonのpackageManager(11.28.0)の 2 か所に書かれていて、すでに食い違っている。pnpm 11 以降は実行中のバージョンがpackageManagerと違うと宣言側をダウンロードして使う(pmOnFailの既定値download)ので、実際に効いているのはpackageManagerだけ。やったこと
dashboard/Dockerfile:pnpm 公式の推奨どおり、ghcr.io/pnpm/pnpm:12から/opt/pnpmをコピーする方式にしたlibatomic.so.1を必要とし、node:*-slimには入っていないため apt が要る。pnpm 12 のバイナリは不要なので、apt なしで済むminimumReleaseAgeに引っかかるので 12.15.0 にしたmise.toml:pnpm = "12"にした(入口なのでメジャーだけ)renovate.json:pnpm のメジャー更新はpackage.json・mise.toml・Dockerfileの 3 か所をまとめて上げる必要があるので、1 つのグループにしたローカルでの確認:
pnpm run ci・pnpm typecheck・pnpm testが通るdocker buildx build --target prodが通り、using pnpm v12.15.0と出る(イメージの pnpm は 12.17.0。packageManagerのバージョンに切り替わっている)node:26-slimに差し替えても同じくビルドが通るrenovate-config-validatorが通るやらなかったこと
closes #1383
資料
🤖 Generated with Claude Code