Skip to content

feat: メッセージから生えてくるやつのつなぎこみ2 - #5592

Merged
aoringo0606 merged 4 commits into
feat/threadfrom
feat/thread-create-events
Nov 14, 2026
Merged

aoringo0606 merged 4 commits into
feat/threadfrom
feat/thread-create-events

Conversation

@aoringo0606

Copy link
Copy Markdown
Collaborator

What

THREAD_CREATED、THREAD_UPDATEDを見るようになる

Why

スレッドが作成されたらスレッドカードを表示するため

Verification

@aoringo0606
aoringo0606 requested a review from a team as a code owner November 13, 2026 15:38
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 72f4f29d-1eb8-4534-99c0-c65dc79029e0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

@aoringo0606

Copy link
Copy Markdown
Collaborator Author

スレッドが沢山あるチャンネルでF5を押したとき、スクロール位置が最後の部分よりも上になる問題は存在します

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.63%. Comparing base (847cecd) to head (ec00a39).
⚠️ Report is 1 commits behind head on feat/thread.

Files with missing lines Patch % Lines
src/store/entities/threads.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           feat/thread    #5592      +/-   ##
===============================================
- Coverage        64.66%   64.63%   -0.03%     
===============================================
  Files              267      267              
  Lines             5521     5526       +5     
  Branches          1162     1163       +1     
===============================================
+ Hits              3570     3572       +2     
- Misses            1689     1692       +3     
  Partials           262      262              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aoringo0606
aoringo0606 changed the base branch from master to feat/thread November 13, 2026 15:42

@uni-kakurenbo uni-kakurenbo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとう、一件だけ確認お願いします :pray-nya:

Comment thread src/store/entities/threads.ts Outdated
const { primaryView } = useMainViewStore()
const view = primaryView.value

if (view.type !== 'channel' || view.channelId !== channel.parentId) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addThread が親チャンネルを判定するのは GET /channels/:id の後なのでスレッドの新規作成・更新のたびにリクエストが送られてあんまりよくなさそう

カード自体は親メッセージの threadId を受けとって fetchThread をするのでカード表示はそれに任せて THREAD_UPDATED はキャッシュ済みのスレッドだけ既存の fetchThread で更新すればよさそう (そうすれば primaryView への依存も多分外せる?)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サイドバーなどで将来的に必要になりそうな部分ではありますが、とりあえず今回のPRでは該当部分を削除します

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かにそうかも
そう思うなら残しておいてもいいよ

@aoringo0606
aoringo0606 merged commit 085ea14 into feat/thread Nov 14, 2026
26 checks passed
@aoringo0606
aoringo0606 deleted the feat/thread-create-events branch November 14, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants