Skip to content

GroupIconコンポーネントにclipIconオプションを追加 - #5602

Merged
rurun418 merged 1 commit into
masterfrom
fix/groupicon
Nov 17, 2026
Merged

rurun418 merged 1 commit into
masterfrom
fix/groupicon

Conversation

@rurun418

@rurun418 rurun418 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What

GroupIconコンポーネントにclipIconオプションを追加

Why

https://q.trap.jp/messages/01a1e2f6-4d8c-76a7-86d4-c1e351d4c84b

Memo

命名が下手かも

Summary by CodeRabbit

  • 新機能
    • グループアイコンの角丸表示を切り替えられるようになりました。既定では従来どおり角丸で表示されます。
  • 変更
    • チーム一覧では、グループアイコンの角丸表示を無効にしました。

@rurun418
rurun418 requested a review from a team as a code owner November 17, 2026 06:01
@github-actions

Copy link
Copy Markdown

@rurun418 rurun418 changed the title add option "clipIcon" GroupIconコンポーネントにclipIconオプションを追加 Nov 17, 2026
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

GroupIconにclipIconプロパティを追加しました。既定値はtrueです。角丸は値がtrueの場合に適用します。TeamListではclip-iconにfalseを指定しています。

Changes: GroupIconの角丸制御

Layer / File(s) Summary
clipIconの定義と適用
src/components/UI/GroupIcon.vue, src/components/Modal/UserModal/ProfileTab/TeamList.vue
GroupIconにclipIconプロパティを追加し、既定値をtrueに設定しました。ルート要素のdata-clip-icon属性に値を反映し、属性値がtrueの場合に角丸を適用します。TeamListではclip-iconにfalseを指定しています。

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Suggested reviewers: uni-kakurenbo

Merge Risk: Minimal · up to d2842

GroupIcon gains an optional prop to turn off its rounded corners. Existing usages are unchanged, and only the team list in the user profile modal opts out. No merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed PRのタイトル「GroupIconコンポーネントにclipIconオプションを追加」は、変更の主目的であるGroupIconへのclipIconプロパティ追加を具体的に示しています。変更内容(GroupIcon.vueでのclipIcon追加、既定値true、data-clip-icon属性による角丸制御、TeamList.vueでのclipIcon=false指定)と一致します。
Description check Passed 説明文は「What」と「Why」を記載しており、テンプレートの主要項目を満たしています。ただし「Why」はリンクのみで、理由の本文がありません。「Verification」と「References」の節はありません。「Memo」は命名に関する懸念を記載していますが、テンプレートにはない項目です。
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/components/Modal/UserModal/ProfileTab/TeamList.vue

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/components/UI/GroupIcon.vue

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eec2843d-c9d2-4ca2-ba85-1d3fed6696d8
Commits

Reviewing files that changed from the base of the PR and between cdfeca3 and d2842f0.

Files selected for processing: 2

  • src/components/Modal/UserModal/ProfileTab/TeamList.vue
  • src/components/UI/GroupIcon.vue

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.68%. Comparing base (cdfeca3) to head (d2842f0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5602   +/-   ##
=======================================
  Coverage   65.68%   65.68%           
=======================================
  Files         228      228           
  Lines        4671     4671           
  Branches      969      969           
=======================================
  Hits         3068     3068           
  Misses       1398     1398           
  Partials      205      205           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rurun418
rurun418 merged commit f7c14ae into master Nov 17, 2026
27 checks passed
@rurun418
rurun418 deleted the fix/groupicon branch November 17, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants