fix: review follow-ups for tracel-runtime and tracel-job

.github/workflows/ci.yml

@@ -2,6 +2,7 @@ name: CI
 
 env:
   CARGO_TERM_COLOR: always
+  FEATURES: tracel/station,tracel/burn,tracel/schema
 
 # For now we execute CI only on PR to save on CI time
 on:
@@ -33,16 +34,16 @@ jobs:
         run: cargo xtask check format
       # --------------------------------------------------------------------------------
       - name: Lint
-        run: cargo xtask check lint
+        run: cargo xtask check --features "$FEATURES" lint
       # --------------------------------------------------------------------------------
       - name: Typos
         uses: tracel-ai/github-actions/check-typos@v11
       # --------------------------------------------------------------------------------
       - name: Unit Tests
-        run: cargo xtask test unit
+        run: cargo xtask test --features "$FEATURES" unit
       # --------------------------------------------------------------------------------
       - name: Integration Tests
-        run: cargo xtask test integration
+        run: cargo xtask test --features "$FEATURES" integration
       # --------------------------------------------------------------------------------
       - name: Documentation Tests
-        run: cargo xtask doc tests
+        run: cargo xtask doc --features "$FEATURES" tests

Cargo.toml

@@ -25,6 +25,8 @@ categories = ["development-tools"]
 burn = { version = "0.22", default-features = false, features = [ "train" ] }
 
 rand = "0.9.2"
+relative-path = "1.9.3"
+rstest = "0.27.0"
 tempfile = "3.27.0"
 
 url = "2.5.8"

README.md

@@ -91,10 +91,8 @@ input, merged onto its default, as its arguments, which the console lists as its
 
 The experiments `Target::experiments` builds in a job, on the thread that runs it, are linked to
 that job, even for runs started on other threads: each one started from them records the job's
-number and input, and prints where it records to stderr as it starts, such as
-`Recording experiment 42: <url>`, which `tracel run` and a remote job's logs show. Experiments
-built another way, such as `ProjectHandle::experiments`, are not linked unless the code links
-them, through `Experiments::attribute`, `arguments` and `on_start`.
+number and input. Experiments built another way, such as `ProjectHandle::experiments`, are not
+linked unless the code links them, through `Experiments::attribute` and `arguments`.
 
 The [`cli`](examples/basics/examples/cli.rs) example in [`examples/basics`](examples/basics) is a
 complete, runnable version.
@@ -103,7 +101,7 @@ complete, runnable version.
 
 | Variable | Value | Default |
 | --- | --- | --- |
-| `TRACEL_TARGET` | `offline` or `console` | `offline` |
+| `TRACEL_TARGET` | `offline`, `console`, or `station` with the `station` feature of `tracel` | `offline` |
 | `TRACEL_RUNS_DIR` | the directory offline runs are recorded under | `./runs` |
 | `TRACEL_ENV` | the console to reach | `Production` |
 | `TRACEL_API_KEY` | an API key or a job token | the stored `tracel login` session |
@@ -159,11 +157,12 @@ Options:
 - A nested field's flag joins the keys with dots and writes `_` as `-`: the field
   `optimizer.weight_decay` is `--optimizer.weight-decay`. A field that is an array, a map, an
   optional object or an enum with data takes a JSON literal, such as `--layers '[64, 32]'`. A
-  boolean flag given no value is `true`.
+  boolean flag given no value is `true`, and takes a value only as `--flag=value`, such as
+  `--shuffle=false`.
 - The input is the default input, then the `--config` file, then the JSON document, then the
   flags, each merged onto the one before, so a later one wins. Launchers pass the JSON document.
-- `help`, `version` and `config` are the command line's names: a field with one of them has no
-  flag, and is set through `--config` or the JSON document.
+- `help` and `config` are the command line's names: a field with one of them has no flag, and is
+  set through `--config` or the JSON document.
 - `--completions <SHELL>` prints the completion script for `bash`, `elvish`, `fish`, `powershell`
   or `zsh`: `cargo run -- --completions bash > cli.bash`.
 

crates/tracel-artifact/src/bundle/memory/tests.rs

@@ -96,18 +96,6 @@ impl BundleDecode for ExampleConfig {
         let config: ExampleConfig = serde_json::from_str(&config_content)
             .map_err(|e| format!("Failed to parse config JSON: {}", e))?;
 
-        // Optionally validate metadata exists (but don't require it for decoding)
-        if let Ok(mut metadata_reader) = source.open(&settings.metadata_filename) {
-            let mut metadata_content = String::new();
-            if metadata_reader
-                .read_to_string(&mut metadata_content)
-                .is_ok()
-                && let Ok(_metadata) = serde_json::from_str::<ConfigMetadata>(&metadata_content)
-            {
-                // Could validate version compatibility here
-            }
-        }
-
         Ok(config)
     }
 }

crates/tracel-console/Cargo.toml

@@ -29,3 +29,7 @@ tracel-experiment-remote = { workspace = true }
 tracel-inference = { workspace = true }
 tracel-models = { workspace = true }
 url = { workspace = true }
+
+[dev-dependencies]
+rstest = { workspace = true }
+tempfile = { workspace = true }

crates/tracel-console/src/console.rs

@@ -1,11 +1,16 @@
+use std::ffi::OsString;
 use std::fmt;
+use std::path::Path;
 use std::sync::{Arc, Mutex, OnceLock, PoisonError};
 use std::time::{Duration, SystemTime};
 
 use tracel_artifact::ReqwestTransferClient;
 use tracel_client::{
     ClientError,
-    console::{Client, Env, TracelCredentials, user::response::UserResponseSchema},
+    console::{
+        Client, Env, FileSessionStore, SessionStoreError, TracelCredentials,
+        user::response::UserResponseSchema,
+    },
 };
 use tracel_datasets::DatasetRegistry;
 use tracel_experiment::Experiments;
@@ -14,7 +19,7 @@ use tracel_models::ModelRegistry;
 use url::Url;
 
 use crate::datasets::ConsoleDatasetOps;
-use crate::env::{CredentialSource, ProjectRef, env_from_environment};
+use crate::env::{CredentialSource, ProjectRef, env_from_environment, env_from_vars};
 use crate::experiment::ConsoleExperimentProvider;
 use crate::inference::ConsoleInferenceProvider;
 use crate::models::ConsoleModelOps;
@@ -92,8 +97,6 @@ pub struct ProjectScope {
     console: Console,
     pub owner: String,
     pub project: String,
-    /// The kind of namespace that owns the project, once read from the console.
-    owner_kind: OnceLock<NamespaceKind>,
 }
 
 impl ProjectScope {
@@ -111,19 +114,9 @@ impl ProjectScope {
     pub fn fetch(&self) -> Result<Project, ConsoleError> {
         let project = self.client()?.get_project(&self.owner, &self.project)?;
         let project = Project::try_from(project)?;
-        let _ = self.owner_kind.set(project.namespace.kind);
         Ok(project)
     }
 
-    /// Returns the kind of namespace that owns the project, fetching the project on the first
-    /// call.
-    pub fn owner_kind(&self) -> Result<NamespaceKind, ConsoleError> {
-        match self.owner_kind.get() {
-            Some(kind) => Ok(*kind),
-            None => self.fetch().map(|project| project.namespace.kind),
-        }
-    }
-
     /// Returns the client that moves files to and from presigned URLs.
     pub fn transfer_client(&self) -> &ReqwestTransferClient {
         &self.console.inner.transfer_client
@@ -236,7 +229,6 @@ impl Console {
                 console: self.clone(),
                 owner: owner.into(),
                 project: project.into(),
-                owner_kind: OnceLock::new(),
             }),
         }
     }
@@ -301,11 +293,28 @@ impl ProjectHandle {
     /// The owner namespace is `TRACEL_NAMESPACE` and the project name `TRACEL_PROJECT`; either
     /// one unset is read from `namespace` or `project` in `tracel.toml` in the current
     /// directory. Fails with [`ConsoleError::NoNamespace`] or [`ConsoleError::NoProject`] when
-    /// neither names it.
+    /// neither names it, and with [`ConsoleError::InvalidTracelToml`] when `tracel.toml`
+    /// cannot be read.
     pub fn from_env() -> Result<Self, ConsoleError> {
-        let console = Console::from_env()?;
-        let project = ProjectRef::from_env()?;
-        Ok(console.project(project.namespace, project.name))
+        Self::from_vars(
+            |name| std::env::var_os(name),
+            Path::new("."),
+            FileSessionStore::for_server,
+        )
+    }
+
+    /// [`from_env`](Self::from_env), reading the variables from `lookup`, `tracel.toml` from
+    /// `dir`, and the stored `tracel login` session from the store `sessions` gives for the
+    /// console's URL.
+    pub fn from_vars(
+        lookup: impl Fn(&str) -> Option<OsString>,
+        dir: &Path,
+        sessions: impl FnOnce(&Url) -> Result<FileSessionStore, SessionStoreError>,
+    ) -> Result<Self, ConsoleError> {
+        let env = env_from_vars(&lookup)?;
+        let credentials = CredentialSource::from_vars(&lookup).resolve_with(&env, sessions)?;
+        let project = ProjectRef::from_vars(&lookup, dir)?;
+        Ok(Console::connect(env, credentials).project(project.namespace, project.name))
     }
 
     /// Returns the console this project is reached through.
@@ -385,23 +394,4 @@ mod tests {
         assert_send_sync::<Console>();
         assert_send_sync::<ProjectHandle>();
     }
-
-    #[test]
-    fn binding_and_scoping_send_no_request() {
-        let console = Console::connect(
-            Env::Development,
-            TracelCredentials::api_key("tcl_key_not_checked_until_the_first_request"),
-        );
-        let project = console.project("owner", "project");
-        let _ = (
-            project.datasets(),
-            project.models(),
-            project.experiments(),
-            project.inference(),
-        );
-
-        assert!(console.inner.connected.get().is_none());
-        assert!(Arc::ptr_eq(&project.console().inner, &console.inner));
-        assert_eq!(console.base_url(), &Env::Development.get_url());
-    }
 }