Skip to content

fix(suite-native): show the Portfolio Tracker assets in the Home asset table - #35089

Open
PeKne wants to merge 1 commit into
developfrom
PeKne/mobile-portfolio-tracker-shows-no-assets-on-home
Open

PeKne wants to merge 1 commit into
developfrom
PeKne/mobile-portfolio-tracker-shows-no-assets-on-home

Conversation

@PeKne

@PeKne PeKne commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

The Home asset table kept only assets on networks enabled in settings. That list drives device discovery; importing a tracked account never adds its network to it, so the Portfolio Tracker's assets were filtered out and Home showed the empty state next to a nonzero total.

With the Portfolio Tracker selected, the table (and the hidden tokens list) now follows the supported networks, the same set the Accounts list uses. For any other device the table uses the same selector as before, so connected and remembered devices and desktop are unchanged.

The change is a private selector in homeAssetTableSelectors.ts plus one regression test.

Notes for QA

  • Hidden tokens list in the Portfolio Tracker

Related Issue

Resolve #35059

Screenshots:

Screenshot 2026-11-16 at 07 49 43

🤖 LLM Test Recommendations

Summary: The change set is focused on the home asset table selectors and their unit tests. The only user-facing behavior directly affected is the asset home overview on the dashboard. A single targeted E2E test (asset-home.test.ts) provides sufficient regression confidence; other tests that merely transitively import the selector file are not impacted by this narrow change.

Changed files (2)
  • suite-common/assets/src/homeAssetTableSelectors.test.ts
  • suite-common/assets/src/homeAssetTableSelectors.ts

Recommended tests (1)

🔴 High priority (1)
  • suite/e2e/tests/dashboard/asset-home.test.ts — This test directly exercises the asset home overview functionality: expanding/collapsing the asset table, hiding small balances, grouping by network, viewing hidden tokens, and verifying total balance and row limits. These are precisely the behaviors computed by the changed selectors in suite-common/assets/src/homeAssetTableSelectors.ts.

⚠️ Changes with no test coverage (1)

  • suite-common/assets/src/homeAssetTableSelectors.test.ts

Updated: 2026-11-16T07:04:46.023Z

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/PeKne/mobile-portfolio-tracker-shows-no-assets-on-home/web/

🔍 Currents Test Results

🔍 Suite desktop test results: View in Currents

🔍 Suite web test results: View in Currents

🔍 Suite native android test results: View in Currents

@PeKne
PeKne requested a review from a team as a code owner November 16, 2026 06:18
@github-actions

Copy link
Copy Markdown

LLM Exploratory Tester: partial

Tested PR #35089 on the provided T3W1 suite-web deployment: the Portfolio Tracker Home asset-table fix and hidden-tokens behavior could not be reached because this preview has no Portfolio Tracker mode, while the desktop Dashboard asset table correctly followed Settings → Networks and matched the Accounts list. Also found that Dashboard's “Add your networks” modal toggles do not persist changes.

  • BUG-1 [medium] Dashboard network toggles do not persist

Download report, including screenshots

…t table

The table keeps only the networks enabled in settings, which is the list
discovery uses for a device. Tracked accounts are imported one by one and
never touch that list, so their assets were filtered out and Home showed the
empty state next to a nonzero total. With the Portfolio Tracker selected the
table now follows the supported networks, as the Accounts list does.

Closes #35059
@PeKne
PeKne force-pushed the PeKne/mobile-portfolio-tracker-shows-no-assets-on-home branch from f11f11e to b29f0c9 Compare November 16, 2026 07:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile: Portfolio Tracker shows no assets on Home despite funded accounts

1 participant