Skip to content

Publishing: Validate segment values on scheduled publish, publish with descendants and create/update-and-publish (closes #24558) - #24559

Merged
Zeegaan merged 3 commits into
v19/devfrom
v19/bugfix/24558-validate-segment-values-on-publish
Nov 14, 2026
Merged

Publishing: Validate segment values on scheduled publish, publish with descendants and create/update-and-publish (closes #24558)#24559
Zeegaan merged 3 commits into
v19/devfrom
v19/bugfix/24558-validate-segment-values-on-publish

fix(core): validate non-default segment values when publishing

b5355c2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 11, 2026 in 1m 40s

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 211 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHxB&open=AaHKD2jBK4qQ3lLsaHxB&pullRequest=24559

Check warning on line 247 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHxE&open=AaHKD2jBK4qQ3lLsaHxE&pullRequest=24559

Check warning on line 226 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHxC&open=AaHKD2jBK4qQ3lLsaHxC&pullRequest=24559

Check failure on line 201 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHxF&open=AaHKD2jBK4qQ3lLsaHxF&pullRequest=24559

Check warning on line 339 in tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Services/PropertyValidationServiceTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'CultureImpact.Explicit(string?, bool)' is obsolete: 'Use ICultureImpactService instead.' 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2sWK4qQ3lLsaHxI&open=AaHKD2sWK4qQ3lLsaHxI&pullRequest=24559

Check failure on line 132 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHw_&open=AaHKD2jBK4qQ3lLsaHw_&pullRequest=24559

Check warning on line 832 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentPublishingServiceTests.Publish.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use trailing comma in multi-line initializers and lists 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2vHK4qQ3lLsaHxJ&open=AaHKD2vHK4qQ3lLsaHxJ&pullRequest=24559

Check warning on line 203 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHxA&open=AaHKD2jBK4qQ3lLsaHxA&pullRequest=24559

Check warning on line 848 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentPublishingServiceTests.Publish.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change return type of method 'BuildSegmentVariantContent' from 'Umbraco.Cms.Core.Models.IContent' to 'Umbraco.Cms.Core.Models.Content' for improved performance 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2vHK4qQ3lLsaHxK&open=AaHKD2vHK4qQ3lLsaHxK&pullRequest=24559

Check warning on line 314 in tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Services/PropertyValidationServiceTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'CultureImpact.Explicit(string?, bool)' is obsolete: 'Use ICultureImpactService instead.' 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2sWK4qQ3lLsaHxH&open=AaHKD2sWK4qQ3lLsaHxH&pullRequest=24559

Check warning on line 236 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHxD&open=AaHKD2jBK4qQ3lLsaHxD&pullRequest=24559

Check warning on line 256 in src/Umbraco.Core/Services/PropertyValidationService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'public' members should come before 'private' members 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AaHKD2jBK4qQ3lLsaHxG&open=AaHKD2jBK4qQ3lLsaHxG&pullRequest=24559
View more details on SonarQubeCloud