Repository navigation
fix(cli): order prerelease versions before their release in update check - #3607
Merged
Merged
Conversation
Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
|
@ShryukGrandhi is attempting to deploy a commit to the Upstash Team on Vercel. A member of the Team first needs to authorize it. |
fahreddinozcan
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compareVersionsin the CLI update check removed the prerelease suffix and compared only the numeric parts, so0.8.3-canary-<datetime>and0.8.3compared as equal. Canary builds use the calculated next version (useCalculatedVersionwith{tag}-{datetime}), so canary users were never told when the matching stable version came out.Fixes #3606
Changes
packages/cli/src/utils/update-check.ts: when the numeric parts are equal, a prerelease now sorts before its release.update-check.test.ts.ctx7.Testing
compareVersions("0.8.3", "0.8.3-canary-...")returns0) and passes with the fix.pnpm --filter ctx7 test: all 379 tests pass.tsc --noEmitpass on the changed files.