Repository navigation
ln: refuse to replace a directory with --backup, -f or -i - #15888
Merged
Merged
Conversation
With a backup option, ln renamed an existing directory at the link name to its backup name and created the link in its place, exiting 0. GNU ln refuses with "cannot overwrite directory" and leaves it untouched; it does the same for -f and -i, where uutils failed with "Is a directory" (after a prompt for -i). Check for a real directory before backing up or prompting. A symlink to a directory is still backed up as a link, as GNU does. Plain ln is unchanged and still reports "File exists". Fixes uutils#15788
0anes0
force-pushed
the
ln-backup-refuse-directory
branch
from
October 27, 2026 11:31
c649054 to
4414bdf
Compare
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-b,-for-i, ln moved an existing directory at the link name aside (or failed with "Is a directory") instead of refusing like GNU does with "cannot overwrite directory". It now checks for a real directory before backing up or prompting; a symlink to a directory is still backed up. Fixes #15788.AI-assisted; reviewed and tested by me.