Repository navigation
fmt: report unreadable files and go on with the rest - #15923
Merged
cakebaker merged 1 commit intoOct 29, 2026
Merged
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15922
fmtnow reports a file operand it can't open or that is a directory, sets exit status 1, and continues with the remaining files, like GNU. The directory case printserror reading 'dir': Is a directory(GNU's wording) instead of a bareread error; the unusedReadErrorvariant and itsfmt-error-readstring are replaced byfmt-error-reading-is-directory(en-US and fr-FR).Found with behave, comparing against GNU coreutils 9.12:
fmt d a.txt,fmt missing a.txt,fmt a.txt d,fmt dandfmt d missingnow give the same stdout, stderr and exit code as GNU.Tests:
test_fmt_directory,test_fmt_continues_after_directory(both skipped on Windows, where a directory can't be opened as a file) andtest_fmt_continues_after_missing_file.