Repository navigation
chore: remove leftover code - #1163
Open
webfansplz wants to merge 1 commit into
Open
webfansplz wants to merge 1 commit into
webfansplz wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vue-devtools-docs canceled.
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small leftovers from earlier versions.
vitePluginClientUrlin the extension's detection payload. The content script readwindow.__VUE_DEVTOOLS_VITE_PLUGIN_CLIENT_URL__, but nothing sets that global, and nothing reads the field. It dates from the older feature that loaded the Vite plugin's client inside the extension panel (feat: inject vite plugin into devtools panel #27), which v9 doesn't have. Removed it fromshared/detection.ts,content/backend.ts,background/tab-state.ts, and the related unit test.packages/vite/package.jsoncopied the client withnode --input-type=commonjsandrequire. It now uses--input-type=moduleandimport, in line with the ESM-only packages.Verification
pnpm --filter vite-plugin-vue-devtools buildpasses. It still removes the oldpackages/vite/clientfirst, the copy matchespackages/client/distexactly, and a missing source still fails the build.pnpm test:smoke:vitepasses (7 tests).tscon the Chrome package is clean.🤖 Generated with Claude Code