Skip to content

chore: remove leftover code - #1163

Open
webfansplz wants to merge 1 commit into
mainfrom
chore/cleanup-leftovers
Open

webfansplz wants to merge 1 commit into
mainfrom
chore/cleanup-leftovers

Conversation

@webfansplz

Copy link
Copy Markdown
Member

Two small leftovers from earlier versions.

  • Unused vitePluginClientUrl in the extension's detection payload. The content script read window.__VUE_DEVTOOLS_VITE_PLUGIN_CLIENT_URL__, but nothing sets that global, and nothing reads the field. It dates from the older feature that loaded the Vite plugin's client inside the extension panel (feat: inject vite plugin into devtools panel #27), which v9 doesn't have. Removed it from shared/detection.ts, content/backend.ts, background/tab-state.ts, and the related unit test.
  • CommonJS in the Vite plugin build script. packages/vite/package.json copied the client with node --input-type=commonjs and require. It now uses --input-type=module and import, in line with the ESM-only packages.

Verification

  • pnpm --filter vite-plugin-vue-devtools build passes. It still removes the old packages/vite/client first, the copy matches packages/client/dist exactly, and a missing source still fails the build.
  • pnpm test:smoke:vite passes (7 tests).
  • Unit and integration tests pass, and tsc on the Chrome package is clean.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 15, 2026 09:06
@netlify

netlify Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit e4679e4
🔍 Latest deploy log https://app.netlify.com/projects/vue-devtools-docs/deploys/6ad0979aa43e7d32d1bab55e

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vue/devtools-agent@1163
npm i https://pkg.pr.new/@vue/devtools-api@1163
npm i https://pkg.pr.new/@vue/devtools-kit@1163
npm i https://pkg.pr.new/vite-plugin-vue-devtools@1163

commit: e4679e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants