Repository navigation
New option "--fillonly" #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dd07f28
New option "--fillonly" to remove "stroke" from generated SVGs and on…
EvilJordan 1f834ba
Tests for --fillonly and correction of indentation in template.svg to…
EvilJordan 272003e
Minor cleanups
EvilJordan 7940a6b
New Illustrator Issues section and fix of existing flags in documenta…
EvilJordan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ type Options struct { | |
| ColorScheme string | ||
| Transparent bool | ||
| GridMode bool | ||
| FillOnly bool | ||
| LineHeight float32 | ||
| } | ||
|
|
||
|
|
@@ -31,6 +32,7 @@ var DefaultOptions = Options{ | |
| MarginSize: xydim.XyDimFloat{X: 0, Y: 0}, | ||
| ColorScheme: "Builtin Dark", | ||
| Transparent: false, | ||
| FillOnly: false, | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. gofmt seem to want to indent this |
||
| LineHeight: 1.0, | ||
| } | ||
|
|
||
|
|
@@ -143,6 +145,7 @@ func Convert(r io.Reader, w io.Writer, opts Options) error { | |
| NrLines: ad.MaxY + 1, | ||
| Lines: lines, | ||
| GridMode: opts.GridMode, | ||
| FillOnly: opts.FillOnly, | ||
| } | ||
| return s.Render(w) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ func Main(env Env) error { | |
| var listColorSchemesFlag = fs.Bool("listcolorschemes", false, "List color schemes") | ||
| var transparentFlag = fs.Bool("transparent", ansitosvg.DefaultOptions.Transparent, "Transparent background") | ||
| var gridModeFlag = fs.Bool("grid", false, "Grid mode (sets position for each character)") | ||
| var fillOnlyFlag = fs.Bool("fillonly", false, "Remove strokes from SVG output (use fills only)") | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably want |
||
| var helpFlag bool | ||
| fs.BoolVar(&helpFlag, "h", false, "") | ||
| fs.BoolVar(&helpFlag, "help", false, "Show help") | ||
|
|
@@ -144,6 +145,7 @@ Example usage: | |
| ColorScheme: *colorSchemeFlag, | ||
| Transparent: *transparentFlag, | ||
| GridMode: *gridModeFlag, | ||
| FillOnly: *fillOnlyFlag, | ||
| }, | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,7 @@ type Screen struct { | |
| NrLines int | ||
| Lines []Line | ||
| GridMode bool | ||
| FillOnly bool | ||
| Dom SvgDom | ||
| } | ||
|
|
||
|
|
||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.