Repository navigation
Update mp3lame to 4.0 from 3.100 and build it without the decoder - #832
Merged
Merged
Conversation
Owner
|
Much better, thanks! |
Dummgelaufen007
added a commit
to Dummgelaufen007/static-ffmpeg
that referenced
this pull request
Oct 12, 2026
Upstream master de497ed (pull requests wader#831 and wader#832) bumps fdk-aac to 3.0.0 and mp3lame to 4.0 and builds mp3lame without the decoder. - Dockerfile is the one of de497ed. - Every variant takes over fdk-aac 3.0.0 and mp3lame 4.0 and their checksums. - The clean and stab variants take over --disable-decoder in mp3lame. The opt variants already had it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #775. Three lines in the lame recipe: version, checksum and
--disable-decoder. No mpg123 and no lld needed.lame 4.0 takes its MP3 decoder from an external libmpg123, and
configurestops with "libmpg123 not found" unless the decoder is switched off (configure.ac, lines 572-595).ffmpeg never reaches that decoder:
lame_set_VBR_quality(configure#L7398), and libmp3lame is used only bylibmp3lame_encoder(#L3848)lame_init,lame_set_*,lame_init_params,lame_get_encoder_delay/framesize,lame_encode_buffer*,lame_encode_flushandlame_close; nohip_*and nolame_set_decode_on_the_flyTested in Alpine 3.24.2 containers on x86_64 and aarch64 (aarch64 under qemu-user emulation): lame 4.0 builds with these flags,
libmp3lame.ahas no reference to mpg123, ffmpeg's configure test links, and an encode through the calls ffmpeg makes returns valid MP3 frames. The full ffmpeg link is left to the CI of this PR.Research and wording by Claude (Anthropic), directed and reviewed by me.