Repository navigation
Conversation
Add signatures for FLAC, HLS playlists, Matroska, AAC in ADTS, and MPEG-TS, and recognize more MP4 brands, matching Gecko. The Canon CR3 brand is excluded so CR3 files aren't sniffed as MP4. Tests: web-platform-tests/wpt#64714. Fixes whatwg#149.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add signatures for FLAC, HLS playlists, Matroska, AAC in ADTS, and MPEG-TS, and recognize more MP4 brands, matching Gecko. The Canon CR3 brand is excluded so CR3 files aren't sniffed as MP4.
Tests: web-platform-tests/wpt#64714.
Fixes #149.
This is needed for opaque-response blocking (whatwg/fetch#1755), which blocks unlabeled responses to media requests unless they sniff as audio or video. Differences from Gecko's
nsMediaSniffer.cpp: acrxmajor brand returns false (Gecko returnsapplication/octet-stream, which ORB treats as a match), ADTS requires a frame length of at least 7, andavifisn't included as it's an image. ADTS with large frames can need more than 1445 bytes, see #218.fetch/orb/tentative/media.sub.html,fetch/orb/tentative/hls.html)(See WHATWG Working Mode: Changes for more details.)
Preview | Diff