Skip to content

Close the nanometre gaps between EMCAL modules - #16142

Merged
sawenzel merged 1 commit into
AliceO2Group:devfrom
sawenzel:swenzel/emcal-module-gaps
Nov 17, 2026
Merged

sawenzel merged 1 commit into
AliceO2Group:devfrom
sawenzel:swenzel/emcal-module-gaps

Conversation

@sawenzel

Copy link
Copy Markdown
Collaborator

This PR fixes the nanometre gaps between neighbouring EMCAL modules reported in https://its.cern.ch/jira/browse/O2-7334.

Neighbouring modules in eta were separated by 0.05–3 nm of supermodule air, and the first module row extruded 67 nm from its supermodule. There were two causes. The TRD1 outer width m2Trd1Dx2 was stored as a float, which tilted the module side faces by about 1e-8 rad against the module chain. The centre of the first module also did not follow the corner convention used for all other modules. The width is now a double, and the first module uses the same convention as the others. Faces of neighbouring modules now coincide to better than 1e-10 cm.

TGeo navigation stepped over these gaps, but VecGeom and native Geant4 navigation stopped in them. There, photons between 0.1 and 1 MeV were killed by the 1 MeV default cut of the air. The effect on the low-energy part of the shower is substantial (3000 photons of 1 GeV/c, ratios to TGeo navigation):

VecGeom before VecGeom after Geant4 after
Compton electrons in lead 0.947 0.983 0.997
photoelectrons in lead 0.928 0.978 1.000
cells per photon, difference −0.68 −0.20 –
EMCAL hits in pp events 0.97 0.99 –

The remaining VecGeom difference comes from the kRelocating navigator; kPropagated agrees with TGeo and is followed up separately. The Geant4 cell counts are not comparable because of a separate cell-index problem with reflected volumes.

Note that the change is not intended to alter the geometry. With TGeo navigation, 2 × 1200 paired pythia8 pp events give EMCAL hit ratios of 1.006 and 1.004 ± 0.010 against dev, and the ROOT overlap check is unchanged.

Assisted by Claude Code.

This fixes the placement of the tilted EMCAL modules and adds a unit test.

- Neighbouring modules in eta were separated by nanometre gaps of supermodule air.
- The TRD1 outer width m2Trd1Dx2 was a float, which tilted the module side faces.
- The centre of the first module did not follow the corner convention of the other modules.
- m2Trd1Dx2 is now a double.
- The first module now uses the same convention as the others.
- A new test checks that the faces of neighbouring modules coincide.

https://its.cern.ch/jira/browse/O2-7334

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jokonig

jokonig commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Hi @sawenzel thanks for finding and fixing that!
We will check what the implications are for the physics analyses (I hope minor)

@sawenzel
sawenzel force-pushed the swenzel/emcal-module-gaps branch from 9c046a4 to 85f9686 Compare November 17, 2026 10:20
@sawenzel

Copy link
Copy Markdown
Collaborator Author

Hi @sawenzel thanks for finding and fixing that! We will check what the implications are for the physics analyses (I hope minor)

@jokonig : Thanks. This should definitely not affect analysis (in production) because it doesn't affect TGeo navigation. It is a geometry consistency (higher precision object placement) fix for Geant4 and VecGeom navigation and prepares for GPU simulation.

@jokonig

jokonig commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Hi @sawenzel, thanks for the clarification! This is reassuring

@sawenzel
sawenzel merged commit 210a2a7 into AliceO2Group:dev Nov 17, 2026
13 checks passed
@sawenzel
sawenzel deleted the swenzel/emcal-module-gaps branch November 17, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants