Repository navigation
Close the nanometre gaps between EMCAL modules - #16142
Merged
Merged
Conversation
This fixes the placement of the tilted EMCAL modules and adds a unit test. - Neighbouring modules in eta were separated by nanometre gaps of supermodule air. - The TRD1 outer width m2Trd1Dx2 was a float, which tilted the module side faces. - The centre of the first module did not follow the corner convention of the other modules. - m2Trd1Dx2 is now a double. - The first module now uses the same convention as the others. - A new test checks that the faces of neighbouring modules coincide. https://its.cern.ch/jira/browse/O2-7334 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Hi @sawenzel thanks for finding and fixing that! |
sawenzel
force-pushed
the
swenzel/emcal-module-gaps
branch
from
November 17, 2026 10:20
9c046a4 to
85f9686
Compare
Collaborator
Author
@jokonig : Thanks. This should definitely not affect analysis (in production) because it doesn't affect TGeo navigation. It is a geometry consistency (higher precision object placement) fix for Geant4 and VecGeom navigation and prepares for GPU simulation. |
Collaborator
|
Hi @sawenzel, thanks for the clarification! This is reassuring |
jokonig
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the nanometre gaps between neighbouring EMCAL modules reported in https://its.cern.ch/jira/browse/O2-7334.
Neighbouring modules in eta were separated by 0.05–3 nm of supermodule air, and the first module row extruded 67 nm from its supermodule. There were two causes. The TRD1 outer width
m2Trd1Dx2was stored as a float, which tilted the module side faces by about 1e-8 rad against the module chain. The centre of the first module also did not follow the corner convention used for all other modules. The width is now a double, and the first module uses the same convention as the others. Faces of neighbouring modules now coincide to better than 1e-10 cm.TGeo navigation stepped over these gaps, but VecGeom and native Geant4 navigation stopped in them. There, photons between 0.1 and 1 MeV were killed by the 1 MeV default cut of the air. The effect on the low-energy part of the shower is substantial (3000 photons of 1 GeV/c, ratios to TGeo navigation):
The remaining VecGeom difference comes from the kRelocating navigator; kPropagated agrees with TGeo and is followed up separately. The Geant4 cell counts are not comparable because of a separate cell-index problem with reflected volumes.
Note that the change is not intended to alter the geometry. With TGeo navigation, 2 × 1200 paired pythia8 pp events give EMCAL hit ratios of 1.006 and 1.004 ± 0.010 against
dev, and the ROOT overlap check is unchanged.Assisted by Claude Code.