fix(error-tracking): match single-quoted and backticked ddDebugId in minified bundles by ilteoood · Pull Request #529 · DataDog/build-plugins

ilteoood · 2026-09-30T15:10:43Z

Summary

Fixes #528 — sourcemap upload fails with No debug ID found in any minified file. Aborting upload. even when the bundled output contains the ddDebugId literal.

Root cause

Some minifiers emit the injected value wrapped in single quotes or backticks rather than the double quotes produced by JSON.stringify(...). Examples include:

ddDebugId:'<uuid>' (single-quoted string)
ddDebugId:\`` (template-literal-style string)
"ddDebugId":'<uuid>' (mixed)

The previous extraction regex only accepted double quotes around the value, so any bundle emitted with a different quote style failed extraction and aborted the upload.

Change

In packages/plugins/error-tracking/src/sourcemaps/debugId.ts, broaden the value portion of DEBUG_ID_RX to accept ", ' and ` while keeping the existing flexibility around the optional quotes on the key:

// Before
const DEBUG_ID_RX = /"?ddDebugId"?:"([0-9a-fA-F-]{36})"/;
// After
const DEBUG_ID_RX = /"?ddDebugId"?:["'`]([0-9a-fA-F-]{36})["'`]/;

Added three regression tests in debugId.test.ts to lock in the new behavior:

unquoted key with single-quoted value (ddDebugId:'<uuid>')
quoted key with single-quoted value ("ddDebugId":'<uuid>')
unquoted key with backticked value (ddDebugId:``)

Verification

yarn test:unit packages/plugins/error-tracking/src/sourcemaps/debugId.test.ts — all 11 tests pass (8 pre-existing + 3 new)
yarn test:unit packages/plugins/error-tracking — 83 tests across 7 suites pass
yarn eslint --quiet <changed files> — clean
yarn prettier --check <changed files> — clean
yarn workspace @dd/error-tracking-plugin typecheck — clean

ilteoood · 2026-10-01T14:30:19Z

@melonsong @tyffical could you please take a look at this?

melonsong · 2026-10-01T14:43:58Z

@ilteoood Hello, thanks for the PR! I've passed this on internally for someone on Error Tracking to review.

jhssilva · 2026-10-01T15:58:23Z

Thanks for the PR. 👍 The changes look good.
One suggestion: Could we enforce that the opening and closing quotes match, using a capture group and backreference?

const DEBUG_ID_RX = /"?ddDebugId"?:(["'])([0-9a-fA-F-]{36})\1/;`

Documentation: capture group

Note: We'll need to apply the same change to datadog-ci.

ilteoood · 2026-10-02T06:33:46Z

Thank you @jhssilva, I've also added a non-regression test
I've also opened the same PR into the datadog-ci repo

Some minifiers wrap the ddDebugId value in single quotes (e.g. ddDebugId:'<uuid>') or backticks (e.g. ddDebugId:`<uuid>`) instead of the double quotes produced by JSON.stringify(...). The previous regex only accepted double quotes around the value, so any bundle emitted with a different quote style failed extraction and triggered 'No debug ID found in any minified file. Aborting upload.' during sourcemap upload. Broaden the value quotes in DEBUG_ID_REGEX to ['"'``] and backreference the opening quote so the closing quote must match. Mirrors the change from DataDog/build-plugins#529. Signed-off-by: Corentin Girard <corentin.girard@datadoghq.com>

…es (#2539) Some minifiers wrap the ddDebugId value in single quotes (e.g. ddDebugId:'<uuid>') or backticks (e.g. ddDebugId:`<uuid>`) instead of the double quotes produced by JSON.stringify(...). The previous regex only accepted double quotes around the value, so any bundle emitted with a different quote style failed extraction and triggered 'No debug ID found in any minified file. Aborting upload.' during sourcemap upload. Broaden the value quotes in DEBUG_ID_REGEX to ['"'``] and backreference the opening quote so the closing quote must match. Mirrors the change from DataDog/build-plugins#529. Signed-off-by: Corentin Girard <corentin.girard@datadoghq.com>

ilteoood · 2026-10-07T08:34:34Z

@amortemousque is there anything else I should do here?

ilteoood · 2026-10-08T09:35:07Z

@amortemousque @Scott-Meyer sorry guys for pinging you again, I see that a new version of the lib has been released without including this fix.
It would be awesome if this could be released soon, to avoid relying on an internal package patch.

ilteoood · 2026-10-13T13:04:33Z

hi @watson, sorry pinging you here as well to receive support on this merge.

watson · 2026-10-13T13:11:29Z

@ilteoood I can see that three of your commits are not signed, which is unfortunately blocking us from merging the PR. Would you be able to sign all the commits in your PR? If not, let me know and I can see if there's a way we can sign them for you. But to land this quicker, it's best if you sign them yourself ☺️

Some minifiers wrap the ddDebugId value in single quotes (e.g. `ddDebugId:'<uuid>'` instead of `ddDebugId:"<uuid>"`). The previous regex only accepted double quotes around the value, so any bundle emitted with single quotes failed extraction and triggered `No debug ID found in any minified file. Aborting upload.` during sourcemap upload (issue DataDog#528). Loosen the value quotes to a ["'"] character class so both quote styles are accepted, while keeping the existing flexibility around the key itself.

Broaden the value quote class in DEBUG_ID_RX to also include backticks, since some minifiers can emit the injected value as a template literal-style string (`ddDebugId:\`<uuid>\``) which the previous regex would not match. Add a regression test covering the new backticked case.

Capture the opening quote and backreference it so a mismatched closing quote (e.g. ddDebugId:'<uuid>") is no longer extracted as a debug ID.

ilteoood · 2026-10-13T14:27:13Z

@watson it should be done now

watson · 2026-10-13T14:52:17Z

@jakub-g do you mind adding a review as well on behalf of the build-plugins team?

ilteoood · 2026-10-21T06:42:25Z

Ping @jakub-g

jakub-g

@ilteoood thanks for the PR! and apologies for the delay. The PR LGTM.

I will make a follow-up PR with some further fixes, unrelated to original issue, but fixing some adjacent possible problems.

In the meantime, I think we can merge this PR. Let's wait for CI.

jakub-g · 2026-10-22T10:28:13Z

I need to get some additional ✅ from codeowning teams to merge it; asking around (not sure why GitHub didn't dispatch those reviews earlier, weird).

crousseaux

lgtm

jakub-g · 2026-10-22T10:58:19Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-22T10:58:23Z

View all feedbacks in Devflow UI.

2026-10-22 10:58:23 UTC ℹ️ Start processing command /merge

2026-10-22 10:58:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2m (p90).

2026-10-22 10:59:49 UTC ℹ️ MergeQueue: This merge request was merged

ilteoood requested a review from a team as a code owner September 30, 2026 15:10

ilteoood requested review from jakub-g and removed request for a team September 30, 2026 15:10

ilteoood changed the title ~~fix(error-tracking): match single-quoted debug-id in minified bundles~~ fix(error-tracking): match single-quoted and backticked ddDebugId in minified bundles Sep 30, 2026

ilteoood mentioned this pull request Oct 2, 2026

fix(sourcemaps): accept single-quoted and backticked ddDebugId values DataDog/datadog-ci#2539

Merged

amortemousque approved these changes Oct 2, 2026

View reviewed changes

ilteoood added 3 commits October 13, 2026 16:22

fix(error-tracking): require matching quotes around ddDebugId value

2e5213e

Capture the opening quote and backreference it so a mismatched closing quote (e.g. ddDebugId:'<uuid>") is no longer extracted as a debug ID.

ilteoood force-pushed the ilteoood/fix-528-double-quoted-debug-id branch from adae3da to 2e5213e Compare October 13, 2026 14:24

amortemousque approved these changes Oct 13, 2026

View reviewed changes

dajiaohuang mentioned this pull request Oct 16, 2026

fix(error-tracking): preserve URL path separators on Windows #589

Open

ilteoood added 2 commits October 19, 2026 14:42

Merge branch 'master' into ilteoood/fix-528-double-quoted-debug-id

317d3de

Merge branch 'master' into ilteoood/fix-528-double-quoted-debug-id

b81cb21

jakub-g approved these changes Oct 22, 2026

View reviewed changes

jakub-g mentioned this pull request Oct 22, 2026

fix(error-tracking): accept single-quoted and backticked ddDebugId keys #616

Open

jakub-g requested a review from a team October 22, 2026 10:24

crousseaux approved these changes Oct 22, 2026

View reviewed changes

jakub-g enabled auto-merge October 22, 2026 10:48

buranmert approved these changes Oct 22, 2026

View reviewed changes

jakub-g disabled auto-merge October 22, 2026 10:54

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Oct 22, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit c3eb959 into DataDog:master Oct 22, 2026
9 checks passed

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Oct 22, 2026

ilteoood deleted the ilteoood/fix-528-double-quoted-debug-id branch October 23, 2026 07:22

Conversation

ilteoood commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Change

Verification

Uh oh!

ilteoood commented Oct 1, 2026

Uh oh!

melonsong commented Oct 1, 2026

Uh oh!

jhssilva commented Oct 1, 2026

Uh oh!

ilteoood commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ilteoood commented Oct 7, 2026

Uh oh!

ilteoood commented Oct 8, 2026

Uh oh!

ilteoood commented Oct 13, 2026

Uh oh!

watson commented Oct 13, 2026

Uh oh!

ilteoood commented Oct 13, 2026

Uh oh!

watson commented Oct 13, 2026

Uh oh!

ilteoood commented Oct 21, 2026

Uh oh!

jakub-g left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakub-g commented Oct 22, 2026

Uh oh!

crousseaux left a comment

Choose a reason for hiding this comment

Uh oh!

jakub-g commented Oct 22, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ilteoood commented Sep 30, 2026 •

edited

Loading

ilteoood commented Oct 2, 2026 •

edited

Loading

jakub-g left a comment •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 •

edited

Loading