Repository navigation
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Keep the earlier Slack migration at version 13 and move the later cancelled-state correction to version 14 without changing either SQL body. Validate unique catalog versions and paired directions without Docker. Co-Authored-By: Codex <noreply@openai.com>
Keep the earlier Slack migration at version 13 and move the later cancelled-state correction to version 14 without changing either SQL body. Validate unique catalog versions and paired directions without Docker. Co-Authored-By: Codex <noreply@openai.com>
Contributor
|
Important Review skippedToo many files! This PR contains 175 files, which is 75 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (175)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 12, 2026
Guard storage, preserve explicit filter clears, paginate complete cycle lists, use local dates and selected language, and prevent accidental submits and editor shortcut conflicts. Scope generated CSS and refresh logo colors on theme changes. Co-Authored-By: Codex <noreply@openai.com>
Guard storage, preserve explicit filter clears, paginate complete cycle lists, use local dates and selected language, and prevent accidental submits and editor shortcut conflicts. Scope generated CSS and refresh logo colors on theme changes. Co-Authored-By: Codex <noreply@openai.com>
Treat both date-only strings and RFC3339 date fields returned by the API as local calendar dates for display and filtering. Co-Authored-By: Codex <noreply@openai.com>
Treat both date-only strings and RFC3339 date fields returned by the API as local calendar dates for display and filtering. Co-Authored-By: Codex <noreply@openai.com>
Distinguish failed loading from a genuinely empty cycle, expose retry progress, preserve successful data on refresh failures, and discard stale requests after navigation or newer attempts. Co-Authored-By: Codex <noreply@openai.com>
Distinguish failed loading from a genuinely empty cycle, expose retry progress, preserve successful data on refresh failures, and discard stale requests after navigation or newer attempts. Co-Authored-By: Codex <noreply@openai.com>
Member
|
Thanks for the effort here! We're not considering a second (v2) UI option. Improvements to the current UI are very welcome, though, so feel free to open focused PRs against the existing pages and components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Part 2 of the opt-in v2 interface adds the shell and domain components: navigation, authentication and creation forms, settings panels, work-item tables/layouts, and reusable list controls. It builds on the foundations in #406. Pages and the interface preference are activated in #401.
Merge sequence
All three upstream PRs are open now, so the author does not need to submit the later stages after an earlier merge. Merge the prerequisites first.
This PR targets
mainbecause the author cannot create prerequisite target branches in Devlaner/devlane. Until #406 lands, its GitHub diff includes the foundations (176 files total), and CodeRabbit may skip it. The isolated 82-file review is available at YSamed#2 and YSamed/devlane@feat/v2-foundations...feat/v2-components.Preserve prerequisite commit ancestry when merging #406 and this PR (use merge commits, if repository settings allow them); GitHub can then reduce subsequent diffs automatically. Squash/rebase merges require updating the downstream heads from main before their diffs and CodeRabbit reviews can shrink. Maintainers can update those heads via GitHub where available. Please leave the prerequisite fork branches intact until the sequence is merged.
Validation
go test -v -race -count=1 ./..., plus UI CI.The duplicate upstream migration version was corrected in the foundations: the earlier Slack migration remains 000013, the later cancelled-state correction is 000014, and both SQL bodies are unchanged. A Docker-free migration catalog regression test is included.
AI assistance
Review fixes
Verified and fixed all nine CodeRabbit findings from #406:
Local validation: complete web typecheck, ESLint, Prettier and production build passed; both isolated prerequisite stages also passed those checks. 35 targeted regression checks passed under each of America/Los_Angeles and Europe/Istanbul (70 checks total). API sources are unchanged by these review fixes. Previous review-fix head passed API CI and UI CI. All nine original CodeRabbit review threads on #406 are resolved.
Follow-up: failed issue loading and retry
The controller now reports issue-load failures separately from successful empty results, exposes retry progress, preserves the last successful list when a refresh fails, and rejects stale completions or delayed retry callbacks after navigation/unmount. Retrying a metadata failure reloads the missing project/workspace as well.
The shared work-item section used by project and cycle pages renders a translated alert with a Try again button instead of the empty-state copy when issue loading fails. This UI is in the components stage; the controller/error state is in foundations.
13 targeted regression checks passed, covering a later-page failure, rendered error vs empty UI, retry progress and recovery, refresh failure, overlapping requests, navigation/unmount, and metadata recovery. Full web typecheck, ESLint, Prettier and production build passed; both prerequisite stages independently passed the same checks. API sources are unchanged. The updated head passed API CI and UI CI. The follow-up issue-load review thread is resolved.