Repository navigation
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This was referenced Oct 12, 2026
Keep the earlier Slack migration at version 13 and move the later cancelled-state correction to version 14 without changing either SQL body. Validate unique catalog versions and paired directions without Docker. Co-Authored-By: Codex <noreply@openai.com>
1 task done
Guard storage, preserve explicit filter clears, paginate complete cycle lists, use local dates and selected language, and prevent accidental submits and editor shortcut conflicts. Scope generated CSS and refresh logo colors on theme changes. Co-Authored-By: Codex <noreply@openai.com>
Treat both date-only strings and RFC3339 date fields returned by the API as local calendar dates for display and filtering. Co-Authored-By: Codex <noreply@openai.com>
Distinguish failed loading from a genuinely empty cycle, expose retry progress, preserve successful data on refresh failures, and discard stale requests after navigation or newer attempts. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Part 2 of the v2 review split adds the shell and domain components in 82 changed files: navigation, auth and creation forms, settings panels, work-item tables/layouts, and shared list controls. Its base is
feat/v2-foundations, so the primitive and localization changes are reviewed separately.These components are prepared for the final page/routing integration; this stage does not enable the v2 preference.
Validation
This isolated stage passed web typecheck, ESLint, Prettier and production build. The complete interface also passed those checks and Go vet. API integration tests require Docker and are delegated to the upstream CI under the author's explicit approval.
Dependency and upstream delivery
Depends on the foundations PR in Devlaner/devlane. This 82-file review is hosted in the author's fork because the author cannot create base branches in the upstream repository. After foundations lands upstream, this branch can be submitted to upstream main with an 82-file diff. Final pages and routing are on
feat/v2-integration; the full upstream integration is Devlaner#401.AI assistance
API migration catalog correction
CI on the reconciled main exposed two existing migrations with version 000013. Keep the earlier Slack migration at 000013 and rename the later cancelled-state correction to 000014, preserving both SQL contents. This restores migration loading for fresh databases and preserves the previously deployed Slack version. A Docker-free catalog regression test rejects duplicate version/direction pairs and requires both up/down files for every version. It fails on the original catalog and passes after the correction; Go vet also passes. Docker-backed API CI passed for the final full integration commit and the foundations commit, including
go test -v -race -count=1 ./.... UI CI also passed for both commits.Previous upstream validation: integration API CI, integration UI CI, foundations API CI, foundations UI CI — all passed.
Review fixes
Verified and fixed all nine CodeRabbit findings from Devlaner#406:
Local validation: complete web typecheck, ESLint, Prettier and production build passed; both isolated prerequisite stages also passed those checks. 35 targeted regression checks passed under each of America/Los_Angeles and Europe/Istanbul (70 checks total). API sources are unchanged by these review fixes. New API/UI CI runs validate the updated heads.
Follow-up: failed issue loading and retry
The controller now reports issue-load failures separately from successful empty results, exposes retry progress, preserves the last successful list when a refresh fails, and rejects stale completions or delayed retry callbacks after navigation/unmount. Retrying a metadata failure reloads the missing project/workspace as well.
The shared work-item section used by project and cycle pages renders a translated alert with a Try again button instead of the empty-state copy when issue loading fails. This UI is in the components stage; the controller/error state is in foundations.
13 targeted regression checks passed, covering a later-page failure, rendered error vs empty UI, retry progress and recovery, refresh failure, overlapping requests, navigation/unmount, and metadata recovery. Full web typecheck, ESLint, Prettier and production build passed; both prerequisite stages independently passed the same checks. API sources are unchanged. CI is running on the updated heads.