Repository navigation
Conversation
org-event
temporarily deployed
to
llm-providers
November 3, 2026 07:26 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
kind/protocol
This was referenced Nov 3, 2026
added 2 commits
November 3, 2026 22:18
FreeRDP-based clients open the advanced input channel (`FreeRDP::Advanced::Input`) and the Microsoft clients do not, so a server can tell them apart, for example to send a codec only FreeRDP decodes reliably. `RdpServerInputHandler::advanced_input_opened` is called when the client accepts the channel; its default does nothing. `BoundInputSlot` forwards it like the other input events.
The three BoundInputSlot handlers repeated the same lock, bound-handler and fallback steps; a `dispatch` helper now holds them once. The `advanced_input_opened` documentation says that the call is not ordered with the advanced-input mouse events, which run as separate tasks.
org-event
force-pushed
the
server-advanced-input-opened
branch
from
November 3, 2026 19:21
36fbbf4 to
e0668ae
Compare
org-event
temporarily deployed
to
llm-providers
November 3, 2026 19:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
risk/high
Contributor
|
This pull request may overlap with #2357. PR 2357's body explicitly lists the same feature, RdpServerInputHandler::advanced_input_opened called when the client accepts FreeRDP::Advanced::Input, noting it is also open as a focused PR; this PR implements exactly that server-side hook plus the BoundInputSlot dispatch refactor and tests. This notice is advisory only. Automated review continues as usual, and how these pull requests relate is for maintainers and authors to decide. Note LLM-assisted content (no human feedback). |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeRDP-based clients open the advanced input channel (
FreeRDP::Advanced::Input) and the Microsoft clients do not, so a server can tell them apart, for example to send a codec only FreeRDP decodes reliably.RdpServerInputHandler::advanced_input_openedis called when the client accepts the channel; its default does nothing.BoundInputSlotforwards it like the other input events.The call is not ordered with the advanced-input mouse events, which run as separate tasks; the trait documentation says so.
BoundInputSlotnow has onedispatchhelper for its three forwarding methods.