Repository navigation
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
/agentic_describe |
|
/agentic_review |
PR Summary by QodoDrop Python 3.10 support and move Bazel to Python 3.11
AI Description
Diagram
High-Level Assessment
Files changed (11)
|
Code Review by Qodo
1. Python 3.10 users lose upgrades
|
|
/agentic_review |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Code review by qodo was updated up to the latest commit 3ba1e07 |
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 1f82a13 |
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit c77376b |
💥 What does this PR do?
Note: hold off on merging this until we can verify this won't affect a large amount of users trying to upgrade or install.
Python
3.10is now EOL and will no longer receive security updates. This PR drops support for Python3.10in theseleniumpackage and moves the base toolchain for Bazel to3.11.Since #18065 was merged to add support for Python
3.15, this change follows our practice of supporting only the five active, non-EOL Python versions (3.11-3.15).This allows us to upgrade dependencies and tooling to versions that no longer support
3.10. It removes a compatibility constraint on dependency updates and makes it easier to benefit from newer releases, including security fixes.requires-python = ">=3.11"rules_pythonto latest3.11requirements.txtwith updated dependenciesrequirements_lock.txtwith pinned dependenciestyping_extensionsas a runtime dependency and removed the last reference of it in code since all type annotations we use are now included in3.11+standard library.🔧 Implementation Notes
rules_pythonchanged the bootstrap'ssys.pathhandling so the Python runtime is added from runfiles rather than from the underlying Bazel repository cache. I updatedpdl_to_jsonto inludeimports = ["."]so it still works.certifiin runtime dependencies guarantees users don't have an older version that contains recently revoked certs.💡 Additional Considerations
3.11introduced aStrEnumclass and now ruff complains we are not using it (UP042). I decided to add that to the ignore rules for now and will possibly fix it with a refactor sometime later. Replacing classFoo(str, Enum)withFoo(StrEnum)can change runtime behavior, particularly the string representation of enum members.🤖 AI assistance
🔄 Types of changes