Repository navigation
Conversation
|
@MohOneX is attempting to deploy a commit to the braedonsaunders' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for this, there's real work in here. The layer violations list, click-to-file, and the health breakdown with most fragile files all sound useful. The analyzer extract is the part I can't take, though. Codeflow is built around If you're up for it, could you split the Architecture panel and Overview changes into their own PR with the analyzer staying inline in |
Show layer violations with click-to-file, Mermaid block inspect, and layer-rule presets in Architecture. Add Overview health breakdown and most fragile files. Keep the analyzer inline in index.html so CodeFlow stays a single-file app.
|
Thanks for the clear feedback — agreed on keeping CodeFlow single-file. I reworked this PR to drop the analyzer extract and keep only the Architecture panel + Overview UX (analyzer remains inline in Monorepo profile + fixture will land as a separate follow-up PR. |
|
Thanks for reworking it so fast, and for keeping the analyzer in index.html. I'll go through the new diff properly. Since it still touches card/ and a lot of the tests, I'll check those changes too before I merge anything. |
|
Follow-up monorepo PR: https://github.com/braedonsaunders/codeflow/pull/ |
braedonsaunders
left a comment
There was a problem hiding this comment.
Went through the reworked diff. The scope is right now: analyzer stays in index.html, the architecture violations list and layer presets look good, the Overview health breakdown is useful, and the shared test loader cuts a lot of copy-pasted vm setup.
One thing blocks it. The em dashes, arrows and ellipses in these files got mangled into garbage characters, looks like an encoding round trip on save:
- card/README.md (all 12 changed lines)
- card/index.js (comments and log strings)
- card/lib/analyzer.js (one comment)
- tests/md-extractors.mjs (one comment)
Could you restore those characters from main? If the only change in a file was the encoding, just drop that file from the PR. The arrows in the new index.html code came through fine.
Once that's fixed I'll do a final pass and then get to #108.
Summary
index.html(single-file app). The earlier extract was removed per maintainer feedback.Test plan
npm testindex.html, check Overview health + Architecture violations / block inspectindex.htmlFollow-up: monorepo profile + fixture will be a separate PR.