Skip to content

Architecture violations UI + Overview health insights - #107

Open
MohOneX wants to merge 1 commit into
braedonsaunders:mainfrom
MohOneX:feat/improve
Open

MohOneX wants to merge 1 commit into
braedonsaunders:mainfrom
MohOneX:feat/improve

Conversation

@MohOneX

@MohOneX MohOneX commented Oct 9, 2026 •

Copy link
Copy Markdown

Summary

  • Architecture panel: layer violations list, click-to-file, Mermaid block inspect, layer-rule presets
  • Overview: health breakdown factors and most fragile files
  • Card receipt grade compare helper
  • Analyzer stays inline in index.html (single-file app). The earlier extract was removed per maintainer feedback.

Test plan

  • npm test
  • Open index.html, check Overview health + Architecture violations / block inspect
  • Confirm Card Action still loads analyzer markers from index.html

Follow-up: monorepo profile + fixture will be a separate PR.

@vercel

vercel Bot commented Oct 9, 2026

Copy link
Copy Markdown

@MohOneX is attempting to deploy a commit to the braedonsaunders' projects Team on Vercel.

A member of the Team first needs to authorize it.

@braedonsaunders

Copy link
Copy Markdown
Owner

Thanks for this, there's real work in here. The layer violations list, click-to-file, and the health breakdown with most fragile files all sound useful.

The analyzer extract is the part I can't take, though. Codeflow is built around index.html being the whole app: open the one file and it works, no second script to load or fetch. Moving ~4,700 lines into analyzer/codeflow-analyzer.js and loading it with <script src> and fetch() breaks that, and it also changes how the Card Action and every test pick up the analyzer.

If you're up for it, could you split the Architecture panel and Overview changes into their own PR with the analyzer staying inline in index.html? I'll review that one. The monorepo profile and fixture would be fine as a separate PR too.

Show layer violations with click-to-file, Mermaid block inspect, and layer-rule presets in Architecture. Add Overview health breakdown and most fragile files. Keep the analyzer inline in index.html so CodeFlow stays a single-file app.
@MohOneX MohOneX changed the title Architecture UX + shared analyzer extract Architecture violations UI + Overview health insights Oct 9, 2026
@MohOneX

MohOneX commented Oct 9, 2026

Copy link
Copy Markdown
Author

Thanks for the clear feedback — agreed on keeping CodeFlow single-file.

I reworked this PR to drop the analyzer extract and keep only the Architecture panel + Overview UX (analyzer remains inline in index.html).

Monorepo profile + fixture will land as a separate follow-up PR.

@braedonsaunders

Copy link
Copy Markdown
Owner

Thanks for reworking it so fast, and for keeping the analyzer in index.html. I'll go through the new diff properly. Since it still touches card/ and a lot of the tests, I'll check those changes too before I merge anything.

@MohOneX

MohOneX commented Oct 9, 2026

Copy link
Copy Markdown
Author

Follow-up monorepo PR: https://github.com/braedonsaunders/codeflow/pull/

@braedonsaunders braedonsaunders left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the reworked diff. The scope is right now: analyzer stays in index.html, the architecture violations list and layer presets look good, the Overview health breakdown is useful, and the shared test loader cuts a lot of copy-pasted vm setup.

One thing blocks it. The em dashes, arrows and ellipses in these files got mangled into garbage characters, looks like an encoding round trip on save:

  • card/README.md (all 12 changed lines)
  • card/index.js (comments and log strings)
  • card/lib/analyzer.js (one comment)
  • tests/md-extractors.mjs (one comment)

Could you restore those characters from main? If the only change in a file was the encoding, just drop that file from the PR. The arrows in the new index.html code came through fine.

Once that's fixed I'll do a final pass and then get to #108.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants