Repository navigation
wasapi: keep device polling reachable without sample events - #323
Merged
hajimehoshi merged 1 commit intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
None
What type of issue is this addressing?
bug
What this PR does | solves
Use a 500 ms wait timeout to keep the existing device poll and suspension predicate reachable when sample-ready events stop. Timeout skips writing; only a signaled event triggers an audio write. Wait errors and unexpected results still propagate. A timeout does not declare device failure or restart an unchanged endpoint. This does not guarantee recovery of every silent same-ID endpoint stall or bound native/COM operation duration.
Validation: An actual render-loop private race harness fails on the original unbounded wait/timeout handling and passes after the fix. It covers repeated timeouts without writes, signal/write, device switch, suspension/resume, wait errors and unexpected results. Wait, clock and COM operations are substituted.
Native macOS arm64 internal race tests and build passed. Windows 386/amd64/arm64 builds passed (compile only). Internal vet and other analyzers passed; full vet retains unchanged baseline Darwin unsafe.Pointer and Windows unkeyed GUID diagnostics. Native Windows playback, reconnect and recovery were not run. Independent review found no blocking issue.