Skip to content

wasapi: keep device polling reachable without sample events #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hajimehoshi merged 1 commit into from
Oct 15, 2026
Merged

wasapi: keep device polling reachable without sample events #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions driver_wasapi_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,16 +434,20 @@ func (c *wasapiContext) loopOnRenderThread() error {
}
c.suspendedCond.L.Unlock()

evt, err := windows.WaitForSingleObject(c.sampleReadyEvent, windows.INFINITE)
// Keep checking suspension and device changes even if the endpoint stops
// signaling its sample-ready event.
evt, err := windows.WaitForSingleObject(c.sampleReadyEvent, 500)
if err != nil {
return err
}
if evt != windows.WAIT_OBJECT_0 {
if evt != windows.WAIT_OBJECT_0 && evt != uint32(windows.WAIT_TIMEOUT) {
return fmt.Errorf("oto: WaitForSingleObject failed: returned value: %d", evt)
}

if err := c.writeOnRenderThread(); err != nil {
return err
if evt == windows.WAIT_OBJECT_0 {
if err := c.writeOnRenderThread(); err != nil {
return err
}
}

// Checking the current default audio device might be an expensive operation.
Expand Down
Loading