Repository navigation
fix(selfupdate): synchronize the Windows rollback reader test - #257
Merged
Merged
Conversation
A visible backup path does not mean the Windows rename has released its DELETE handle. Opening a reader in that interval produces a sharing violation before the rollback behavior can be exercised. The test needs the installer at its next retry boundary before acquiring the rollback reader, so its result reflects rollback behavior rather than filesystem-call scheduling.
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI can verify self-update rollback instead of failing on a sharing violation while opening the backup, as in https://github.com/kenn-io/kit/actions/runs/40893193852/attempts/1.
The test waits for the installer to release its rename handle before it opens the backup reader.