Skip to content

fix(selfupdate): synchronize the Windows rollback reader test #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesm merged 1 commit into from
Oct 29, 2026
+3 −0
Merged

fix(selfupdate): synchronize the Windows rollback reader test #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions selfupdate/selfupdate_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ func TestInstallBinaryWaitsForRollbackReader(t *testing.T) {
_, statErr := os.Stat(dst)
return err == nil && len(backups) == 1 && os.IsNotExist(statErr)
}, time.Second, 5*time.Millisecond)
// The renamed path is visible before Replace closes its handle.
// Wait for the installer to reach its next retry before opening it.
synctest.Wait()
backup, err = os.Open(backups[0])
require.NoError(t, err)
defer func() { _ = backup.Close() }()
Expand Down