Repository navigation
docs: a run outlives its stream; Stop means Cancel - #4
Merged
Merged
Conversation
With ResumeRun, output after a dropped stream can be recovered, which only helps if the run keeps going. Document the behaviour: - Closing a Run stream before Accepted cancels the call. - After Accepted, a closed or lost stream does not stop the run. It continues until it finishes, hits a limit or is cancelled. - Clients call Cancel when the user stops a run. - A run keeps its concurrency slot until Finished, even after its stream dropped. No change to the .proto files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResumeRun(v0.4.0) exists so that output after a dropped stream can be recovered. That only works if the run keeps going after the drop. This PR documents the change in run lifecycle; the backend implements it in kingsejong-lang/playground-backend#8. Docs only; the.protofiles are unchanged.Design
Acceptedcancels the call, and nothing runs.Accepted, a closed or lost stream does not stop the run. This covers an aborted fetch, a network drop and a gateway restart. The run continues until it finishes, hits a limit or is cancelled.Cancel.Finished.Cancelno longer says "(+ aborting the stream)".Finished, including after its stream dropped.ResumeRuninstead ofGetExecution.Testing
Not verified
ExecutionService.Cancelinexecution.protostill reads "e.g. from another tab". It is left unchanged because this PR changes no proto files, and it can be reworded in the next contract release.