Repository navigation
feat(make): Google/Apple sign-in fallback + step logging (v0.149.0) - #310
Merged
Merged
Conversation
A tap whose sign-in hasn't come back in 6 s shows 'Nothing happening? Use your email below instead.' Each step (tap/token/closed/error/script_failed/ stall) posts to /sing/make/social-event for the action log. Google taps are detected via window blur onto its iframe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012RYLVUT9R9DTcUZB1zhh88
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012RYLVUT9R9DTcUZB1zhh88
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live 2026-11-05: a singer's Google/Apple taps on make-it did nothing, she had no way forward, and the box never heard about it.
POST /sing/make/social-eventlogs each step (tap, token, no_token, closed, error, script_failed, stall) at INFO and in the action log. Google taps are detected via window blur onto its iframe.Tests: 3 integration and 3 e2e; the existing social route mocks were narrowed to
social?*. Build host: 48/48 make-it and account-link e2e tests pass. The broader run passes except the pre-existingTestShellHeaderlayout test.Local CodeRabbit skipped (live show follow-up), so no ignore line.
🤖 Generated with Claude Code
https://claude.ai/code/session_012RYLVUT9R9DTcUZB1zhh88