[beveradb]

Follow-up to #310. A test on production found the window-blur check misses some Google taps (the button is a cross-origin iframe). GIS renderButton now also gets its documented click_listener, with blur kept as a backup and taps within 1.5 s de-duplicated.

Verified in Chromium against the live page with this make.js swapped in: one tap event, popup opened, then stall and the email hint.

Local CodeRabbit skipped, so no ignore line.

🤖 Generated with Claude Code

https://claude.ai/code/session_012RYLVUT9R9DTcUZB1zhh88

Summary by CodeRabbit

• Bug Fixes
  • Improved detection of Google sign-in taps, with duplicate reports counted only once.
• Documentation
  • Updated the changelog with the sign-in detection change and verification results.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Google sign-in tap detection now uses GIS click_listener alongside the window-blur fallback. Same-provider taps detected within 1.5 seconds count once. The project version and changelog were updated to v0.149.1.

Changes

Google sign-in tap detection

Layer / File(s)	Summary
Google tap reporting and release notes kj-controller/static-sing/make.js, kj-controller/pyproject.toml, docs/CHANGELOG.md	The Google button invokes a tap callback stored on its holder. The blur fallback remains active, and same-provider taps within 1.5 seconds are ignored. The project version and changelog were updated to v0.149.1.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Low · up to 1266d

The Google detection change has bounded fallback gaps: a rapid Apple retry or backward device-clock adjustment can prevent the email hint from appearing if sign-in stalls. Sign-in itself remains available; address these gaps or explicitly accept them before merging.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit taps the Google sign,
The click and blur both send a sign.
One tap counts once within the time,
While changelog notes the version climb.
Then hops away, content and fine.}