Skip to content

Add [undraft-comment] handler to notify when a PR is being undrafted - #2560

Merged
Urgau merged 1 commit into
rust-lang:mainfrom
Urgau:undraft-comment
Nov 10, 2026
Merged

Urgau merged 1 commit into
rust-lang:mainfrom
Urgau:undraft-comment

Conversation

@Urgau

@Urgau Urgau commented Nov 9, 2026

Copy link
Copy Markdown
Member

Address #2555 in the simplest way possible by adding a new handler [undraft-comment] that post a comment when the author (or someone else) clicks the "Ready for review" button.

[undraft-comment]

The handler takes no options, and immediately hides the comment (see #2555 (comment)).

This pull request has been undrafted.

I oscillated between [ready-for-review] and [undraft-comment], but steeled on the later since we already have other review handlers (didn't want to confuse users), but also bc [ready-for-review-comment] seems unnecessarily long.

cc @RalfJung

@Urgau
Urgau requested a review from Kobzol November 9, 2026 22:50
Comment thread src/handlers/undraft_comment.rs Resolved

@Kobzol Kobzol left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. It might be a bit confusing at first that the comment will immediately disappear, but I think that's fine.

View changes since this review

@Urgau
Urgau enabled auto-merge November 10, 2026 17:45
@Urgau
Urgau added this pull request to the merge queue Nov 10, 2026
Merged via the queue into rust-lang:main with commit c8abc45 Nov 10, 2026
4 checks passed
@Urgau
Urgau deleted the undraft-comment branch November 10, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants