Repository navigation
fix(codec): preserve sparse array slots in state previews - #1168
Open
shuaiyafei wants to merge 1 commit into
Open
shuaiyafei wants to merge 1 commit into
shuaiyafei wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Materialize array preview entries with
Array.fromso sparse slots are represented as explicit encodedundefinedvalues.Previously,
slice(...).map(...)retained holes in the preview array. A JSON transport then converted those holes tonull, which is not aValueEntryand cannot be read aspreview.key/preview.valueby the state inspector.For example:
The encoder now returns a dense preview with the original indices, without filling or mutating the inspected source array.
Regression Coverage
Both regression tests failed before the encoder change and pass with the fix.
Validation
pnpm lintpnpm test: 407 tests passed across 67 filespnpm typecheckpnpm build