Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kit/src/codec/encode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ function encodeUnsafe(value: unknown, state: EncodeState): EncodedValue {
preview:
state.depth >= state.maxDepth
? []
: value.slice(offset, offset + state.maxEntries).map((item, index) => ({
: Array.from(value.slice(offset, offset + state.maxEntries), (item, index) => ({
key: String(index + offset),
value: encode(item, nextState(state)),
})),
Expand Down
38 changes: 38 additions & 0 deletions tests/unit/codec/encode-value.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,44 @@ import { encodeValue } from '../../../packages/kit/src/codec/encode'
import { createDeepCyclicStateFixture } from '../../fixtures'

describe('encodeValue', () => {
it('encodes sparse array slots as explicit entries that survive JSON transport', () => {
const value: unknown[] = []
value.length = 3
value[1] = 'visible'

const encoded = encodeValue(value)
const transported = JSON.parse(JSON.stringify(encoded))

expect(transported).toMatchObject({
kind: 'array',
length: 3,
preview: [
{ key: '0', value: { kind: 'undefined' } },
{ key: '1', value: { kind: 'string', value: 'visible' } },
{ key: '2', value: { kind: 'undefined' } },
],
})
expect(Object.hasOwn(value, 0)).toBe(false)
expect(Object.hasOwn(value, 2)).toBe(false)
})

it('keeps sparse array preview keys aligned with the requested offset', () => {
const value: unknown[] = []
value.length = 5
value[3] = 42

const encoded = encodeValue(value, { entryOffset: 2, maxEntries: 2 })

expect(encoded).toMatchObject({
kind: 'array',
length: 5,
preview: [
{ key: '2', value: { kind: 'undefined' } },
{ key: '3', value: { kind: 'number', value: 42 } },
],
})
})

it('preserves class names and enumerable fields for EventTarget subclasses', () => {
class Dialog extends EventTarget {
id = 'dialog-1'
Expand Down
Loading